Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2810373003: [Payments] Display label and price in line item section in the same available width (Closed)

Created:
3 years, 8 months ago by gogerald1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Display label and price in line item section in the same available width The label is displayed in at most three lines in focused mode. Also truncate the end of the label to display it in a single line in collapsed mode BUG=711322 Review-Url: https://codereview.chromium.org/2810373003 Cr-Commit-Position: refs/heads/master@{#464572} Committed: https://chromium.googlesource.com/chromium/src/+/fa0d37906fe37050f8cb43f0efd4fcf55f12f397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java View 4 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
gogerald1
Hi rouslan@, ptal
3 years, 8 months ago (2017-04-13 21:23:00 UTC) #8
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-13 21:23:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810373003/1
3 years, 8 months ago (2017-04-13 21:38:14 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:26:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa0d37906fe37050f8cb43f0efd4...

Powered by Google App Engine
This is Rietveld 408576698