Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2810333009: Fix non-anti-aliased frame update. (Closed)

Created:
3 years, 8 months ago by capn
Modified:
3 years, 8 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix non-anti-aliased frame update. m_contentsCangeCommitted (now renamed to m_contentsChangeResolved) was not getting set on non-anti-aliased DrawingBuffers, causing us to always skip setting m_animationFrameInProgress to true. This in turn skips calling glReadPixels() for CPU-composited frames. BUG=707298, 608873 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2793653002 Cr-Commit-Position: refs/heads/master@{#461542} (cherry picked from commit 5f8b467781b1b08d611e1d05f31c10dee5538edb) Review-Url: https://codereview.chromium.org/2810333009 . Cr-Commit-Position: refs/branch-heads/3029@{#724} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3c777beab66117a31006f039de191c9a9dccefc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 6 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
capn
PTAL. Merge approved: https://bugs.chromium.org/p/chromium/issues/detail?id=707298#c17 I'm not a committer, so please go ahead and land this ...
3 years, 8 months ago (2017-04-14 22:38:35 UTC) #2
Ken Russell (switch to Gerrit)
3 years, 8 months ago (2017-04-14 23:04:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c777beab66117a31006f039de191c9a9dccefc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698