Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2810333005: Replace ASSERT_NOT_REACHED in modules/indexeddb (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 8 months ago
Reviewers:
tkent, jsbell
CC:
chromium-reviews, haraken, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED in modules/indexeddb Replace ASSERT_NOT_REACHED with NOTREACHED respectively in third_party/WebKit/Source/modules/indexeddb BUG=707641 Review-Url: https://codereview.chromium.org/2810333005 Cr-Commit-Position: refs/heads/master@{#464711} Committed: https://chromium.googlesource.com/chromium/src/+/0f4782f04c3766c34a6ee1fbc69bd815d724e977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Hwanseung Lee
@tkent PTAL, thank you. i searched missing things which is not replaced. so i found ...
3 years, 8 months ago (2017-04-13 16:17:36 UTC) #6
jsbell
lgtm
3 years, 8 months ago (2017-04-13 16:20:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810333005/1
3 years, 8 months ago (2017-04-14 10:24:20 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 10:29:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f4782f04c3766c34a6ee1fbc69b...

Powered by Google App Engine
This is Rietveld 408576698