Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2810323003: Remove ERR_QUIC_BROKEN_ERROR and instead use ERR_QUIC_PROTOCOL_ERROR (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ERR_QUIC_BROKEN_ERROR and instead use ERR_QUIC_PROTOCOL_ERROR in conjunction with checking that the alt-service is actually broken. This is doable now that https://codereview.chromium.org/2805043004/ has landed. Review-Url: https://codereview.chromium.org/2810323003 Cr-Commit-Position: refs/heads/master@{#464298} Committed: https://chromium.googlesource.com/chromium/src/+/514a44a8622bf6ac09b9b926bbeeee6bde170a43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M net/base/net_error_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 2 chunks +13 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-12 22:11:37 UTC) #2
Jana
lgtm
3 years, 8 months ago (2017-04-13 00:58:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810323003/1
3 years, 8 months ago (2017-04-13 01:00:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/361308)
3 years, 8 months ago (2017-04-13 03:11:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810323003/1
3 years, 8 months ago (2017-04-13 03:35:28 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:47:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/514a44a8622bf6ac09b9b926bbee...

Powered by Google App Engine
This is Rietveld 408576698