In-place change of Range::testRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
Review-Url: https://codereview.chromium.org/2810313003
Cr-Commit-Position: refs/heads/master@{#464909}
Committed: https://chromium.googlesource.com/chromium/src/+/c82bb4760bc368ce89d3e30abe617f995fe7c6b5

[Hwanseung Lee, 2017-04-13 11:17:05]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 11:17:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-13 12:30:09]

Description was changed from

==========
In-place change of Range::testRects() and boundingBox() to EphemeralRange.

this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite  updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

to

==========
In-place change of Range::testRects() and boundingBox() to EphemeralRange.

this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

[commit-bot: I haz the power, 2017-04-13 12:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:34:38]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-13 12:36:30]

Description was changed from

==========
In-place change of Range::testRects() and boundingBox() to EphemeralRange.

this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

to

==========
In-place change of Range::testRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

[Hwanseung Lee, 2017-04-13 12:36:31]

hs1217.lee@samsung.com changed reviewers:
+ yosin@chromium.org

[Hwanseung Lee, 2017-04-13 12:37:37]

PTAL, thank you.

[yosin_UTC9, 2017-04-14 01:08:51]

Good shape!
Please see nits.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (left):

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1462: void
Range::TextRects(Vector<IntRect>& rects, bool use_selection_height) const {
Note: |use_selection_height| is default to false and all call sites, actually
one, pass |false| as default.
So, we don't need to have it.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1459: const Vector<IntRect> rects =
computeTextRects(EphemeralRange(this));
nit: s/Vector<IntRect>/Vector<IntRect>&/

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1468: Node* start_container =
start_position.ComputeContainerNode();
nit: s/Node*/Node* const/

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1470: Node* end_container =
end_position.ComputeContainerNode();
nit: s/Node*/Node* const/

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1474: for (Node& node :
range.Nodes()) {
nit: s/Node&/const Node&/

It is nice to use range-for instead of using |stop_node| and
|NodeTraversal::Next()|.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1475: LayoutObject* layoutObject =
node.GetLayoutObject();
nit: s/LayoutObject*/LayoutObject* const/

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1484:
layout_text->AbsoluteRectsForRange(rects, start_offset, end_offset);
Note: |LayoutText::AbsoulteRectsForRange()| takes |use_selection_height| as
default parameter to |false|,
so, we don't need to pass it.

[yosin_UTC9, 2017-04-14 01:09:05]

Description was changed from

==========
In-place change of Range::testRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

to

==========
In-place change of Range::textRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

[Hwanseung Lee, 2017-04-14 23:51:34]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:51:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-15 01:01:12]

Patchset #2 (id:20001) has been deleted

[Hwanseung Lee, 2017-04-15 01:01:18]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 01:02:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 02:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 02:43:47]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-15 02:53:51]

Patchset #2 (id:40001) has been deleted

[Hwanseung Lee, 2017-04-15 02:54:12]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 02:54:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-15 02:54:33]

@yosin
PTAL. thank you.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (left):

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1462: void
Range::TextRects(Vector<IntRect>& rects, bool use_selection_height) const {
On 2017/04/14 01:08:51, yosin_UTC9 wrote:
> Note: |use_selection_height| is default to false and all call sites, actually
> one, pass |false| as default.
> So, we don't need to have it.

right. this line was removed.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1459: const Vector<IntRect> rects =
computeTextRects(EphemeralRange(this));
On 2017/04/14 01:08:50, yosin_UTC9 wrote:
> nit: s/Vector<IntRect>/Vector<IntRect>&/

Done.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1468: Node* start_container =
start_position.ComputeContainerNode();
On 2017/04/14 01:08:51, yosin_UTC9 wrote:
> nit: s/Node*/Node* const/

Done.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1470: Node* end_container =
end_position.ComputeContainerNode();
On 2017/04/14 01:08:51, yosin_UTC9 wrote:
> nit: s/Node*/Node* const/

Done.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1474: for (Node& node :
range.Nodes()) {
On 2017/04/14 01:08:51, yosin_UTC9 wrote:
> nit: s/Node&/const Node&/
> 
> It is nice to use range-for instead of using |stop_node| and
> |NodeTraversal::Next()|.

Done.

https://codereview.chromium.org/2810313003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Range.cpp:1475: LayoutObject* layoutObject =
node.GetLayoutObject();
On 2017/04/14 01:08:51, yosin_UTC9 wrote:
> nit: s/LayoutObject*/LayoutObject* const/

Done.

[commit-bot: I haz the power, 2017-04-15 04:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 04:19:53]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-17 06:35:34]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-04-17 06:35:34]

lgtm

+tkent@ for OWNERS review.

[tkent, 2017-04-17 06:41:54]

lgtm

[Hwanseung Lee, 2017-04-17 07:22:58]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-17 07:23:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 08:53:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492413778861070,
"parent_rev": "73e6a569acfd3b3b5ecc4f0ec2c0945740e9cd2c", "commit_rev":
"c82bb4760bc368ce89d3e30abe617f995fe7c6b5"}

[commit-bot: I haz the power, 2017-04-17 08:53:11]

Description was changed from

==========
In-place change of Range::textRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202
==========

to

==========
In-place change of Range::textRects() and boundingBox() to EphemeralRange.

In-place change of Range::textRects() and boundingBox()
to EphemeralRange version in "Range.cpp".
this patch is second step to use EphemeralRange in
updateMarkerRenderedRect().

we are progressing three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
 (https://codereview.chromium.org/2776103002/)
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange
 instead of Range

BUG=691202

Review-Url: https://codereview.chromium.org/2810313003
Cr-Commit-Position: refs/heads/master@{#464909}
Committed:
https://chromium.googlesource.com/chromium/src/+/c82bb4760bc368ce89d3e30abe61...
==========

[commit-bot: I haz the power, 2017-04-17 08:53:12]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c82bb4760bc368ce89d3e30abe61...