Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2810233003:
Count usage of mediastream audio and video constraints. (Closed)
|
Created:
3 years, 8 months ago by Guido Urdaneta Modified:
3 years, 8 months ago CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, foolip, haraken, tommyw+watchlist_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionCount usage of mediastream audio and video constraints.
This will help ascertain which nonstandard constraints are good
candidates for standardization.
BUG=709931
Review-Url: https://codereview.chromium.org/2810233003
Cr-Commit-Position: refs/heads/master@{#464454}
Committed: https://chromium.googlesource.com/chromium/src/+/fe1505549280fe1b7e4b7a4c5907a71b66a8c809
Patch Set 1 #Patch Set 2 : format #Patch Set 3 : Add histograms.xml #Patch Set 4 : fix bug that broke bots, add new counters #
Messages
Total messages: 30 (21 generated)
Description was changed from ========== Count usage of mediastream audio and video constraints. This will help ascertain which nonstandard constraints are good candidates for standardization. BUG=709931 ========== to ========== Count usage of mediastream audio and video constraints. This will help ascertain which nonstandard constraints are good candidates for standardization. BUG=709931 ==========
guidou@chromium.org changed reviewers: + foolip@chromium.org
Hi, PTAL. I couldn't update the histograms file because the script is failing on my machine with a strange error. I'll fix that before landing.
lgtm
guidou@chromium.org changed reviewers: + haraken@chromium.org
haraken@: Can you take a look at histograms.xml?
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM
Made some changes. Can you take another look?
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
guidou@chromium.org changed reviewers: + jochen@chromium.org - foolip@chromium.org, haraken@chromium.org
jochen@: Perhaps you can look at the latest patchset of this CL? It was already LGTM, but I made a change afterwards and it's already too late for the original reviewers.
jochen@chromium.org changed reviewers: + foolip@chromium.org, haraken@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by guidou@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2810233003/#ps60001 (title: "fix bug that broke bots, add new counters")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492102956239480,
"parent_rev": "19da2957967998c8c9fcf43534f26d4f6297d24b", "commit_rev":
"fe1505549280fe1b7e4b7a4c5907a71b66a8c809"}
Message was sent while issue was closed.
Description was changed from ========== Count usage of mediastream audio and video constraints. This will help ascertain which nonstandard constraints are good candidates for standardization. BUG=709931 ========== to ========== Count usage of mediastream audio and video constraints. This will help ascertain which nonstandard constraints are good candidates for standardization. BUG=709931 Review-Url: https://codereview.chromium.org/2810233003 Cr-Commit-Position: refs/heads/master@{#464454} Committed: https://chromium.googlesource.com/chromium/src/+/fe1505549280fe1b7e4b7a4c5907... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/fe1505549280fe1b7e4b7a4c5907... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
