Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2810203002: Revert of [wasm] instantiate expressed in terms of compile (Closed)

Created:
3 years, 8 months ago by Michael Hablich
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] instantiate expressed in terms of compile (patchset #6 id:140001 of https://codereview.chromium.org/2806073002/ ) Reason for revert: Roll blocker: https://bugs.chromium.org/p/chromium/issues/detail?id=710824 Original issue's description: > [wasm] instantiate expressed in terms of compile > > Today, the semantics of: > > WebAssembly.instantiate > > and > > WebAssembly.compile().then(new WebAssemblyInstance) > > are subtly different, to the point where attempting the proposed > change uncovered bugs. > > In the future, it's possible that .instantiate actually have different > semantics - if we pre-specialized to the provided ffi, for example. > Right now that's not the case. > > This CL: > - gets our implementation closer to what developers may write using > the compile -> new Instance alternative, in particular wrt promise > creation. By reusing code paths, we uncover more bugs, and keep > maintenance cost lower. > > - it gives us the response-based WebAssembly.instantiate implicitly. > Otherwise, we'd need that same implementation on the blink side. The > negative is maintenance: imagine if the bugs I mentioned could only be > found when running in Blink. > > BUG=chromium:697028 > > Review-Url: https://codereview.chromium.org/2806073002 > Cr-Commit-Position: refs/heads/master@{#44592} > Committed: https://chromium.googlesource.com/v8/v8/+/7829af3275ff4644a2d0a1270abe1a1e4415e9fb TBR=bradnelson@chromium.org,ahaas@chromium.org,adamk@chromium.org,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:697028 Review-Url: https://codereview.chromium.org/2810203002 Cr-Commit-Position: refs/heads/master@{#44614} Committed: https://chromium.googlesource.com/v8/v8/+/d3f1d5c50cd6ada48371c1eb2560d2b0ec24533a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -196 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/wasm/wasm-js.cc View 8 chunks +46 lines, -113 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/instantiate-run-basic.js View 1 chunk +3 lines, -17 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 2 chunks +2 lines, -0 lines 0 comments Download
D test/mjsunit/wasm/wasm-api-overloading.js View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [wasm] instantiate expressed in terms of compile
3 years, 8 months ago (2017-04-12 13:27:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810203002/1
3 years, 8 months ago (2017-04-12 13:27:46 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 13:28:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d3f1d5c50cd6ada48371c1eb2560d2b0ec2...

Powered by Google App Engine
This is Rietveld 408576698