Chromium Code Reviews| Index: ios/chrome/browser/ui/stack_view/stack_view_controller_private.h |
| diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h b/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h |
| index 0bdbdf1c7e82d0d42b9d130b9d676faff4cbc309..d584d7b1a3a14fa6eca57583bfdd5b2c6c9b385b 100644 |
| --- a/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h |
| +++ b/ios/chrome/browser/ui/stack_view/stack_view_controller_private.h |
| @@ -68,7 +68,7 @@ typedef enum { |
| - (CGRect)inactiveDeckRegion; |
| // The currently active card set. |
| -@property(nonatomic, readonly) CardSet* activeCardSet; |
| +@property(weak, nonatomic, readonly) CardSet* activeCardSet; |
|
marq (ping after 24h)
2017/04/13 17:17:27
nonatomic, weak, readonly
stkhapugin
2017/04/14 09:44:29
Done. Thanks. I just need to write a presubmit for
|
| // The current transition style. |
| @property(nonatomic, assign) StackTransitionStyle transitionStyle; |
| @@ -78,13 +78,13 @@ typedef enum { |
| @property(nonatomic, assign) BOOL transitionWasCancelled; |
| // The owner of |transitionToolbarController|. |
| -@property(nonatomic, retain) id<ToolbarOwner> transitionToolbarOwner; |
| +@property(nonatomic, strong) id<ToolbarOwner> transitionToolbarOwner; |
| // The toolbar controller used in transition animations. |
| -@property(nonatomic, retain) ToolbarController* transitionToolbarController; |
| +@property(nonatomic, strong) ToolbarController* transitionToolbarController; |
| // The dummy view used in the transition animation. |
| -@property(nonatomic, retain) UIView* dummyToolbarBackgroundView; |
| +@property(nonatomic, strong) UIView* dummyToolbarBackgroundView; |
| // The cached frame of the transition toolbar's frame. |
| @property(nonatomic, assign) CGRect transitionToolbarFrame; |
| @@ -92,7 +92,7 @@ typedef enum { |
| // Records which card was tapped mid-presentation animation, if any. |
| // TODO(crbug.com/546209): Implement reversed animations for dismissing with a |
| // new selected card mid-presentation. |
| -@property(nonatomic, retain) StackCard* transitionTappedCard; |
| +@property(nonatomic, strong) StackCard* transitionTappedCard; |
| // |YES| if there is card set animation being processed. |
| @property(nonatomic, readonly) BOOL inActiveDeckChangeAnimation; |