[Payments] Change how the dialog gets destroyed.

chrome/browser/ui/views/payments/view_stack.h

Index: chrome/browser/ui/views/payments/view_stack.h
diff --git a/chrome/browser/ui/views/payments/view_stack.h b/chrome/browser/ui/views/payments/view_stack.h
index 8b94104160ab1e8b66c0f4dde2f4b1299076b163..93815b041ecea3f783866786feaa7eeb5c3a18b8 100644
--- a/chrome/browser/ui/views/payments/view_stack.h
+++ b/chrome/browser/ui/views/payments/view_stack.h
@@ -59,11 +59,11 @@ class ViewStack : public views::BoundsAnimatorObserver,
   void OnBoundsAnimatorProgressed(views::BoundsAnimator* animator) override {}
   void OnBoundsAnimatorDone(views::BoundsAnimator* animator) override;
 
-  std::vector<std::unique_ptr<views::View>> stack_;
-
   std::unique_ptr<views::BoundsAnimator> slide_in_animator_;
   std::unique_ptr<views::BoundsAnimator> slide_out_animator_;
 
+  std::vector<std::unique_ptr<views::View>> stack_;

[Mathieu, 2017/04/12 13:29:02]

The order is important here, because views need to be destroyed before the
view-stack-wide animators and members get destroyed in reverse order. Otherwise
you'd destroy the two animators before all the views, which is wrong.

[anthonyvd, 2017/04/12 14:19:36]

Good catch, can you please add a comment about this?

[Mathieu, 2017/04/12 14:24:23]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ViewStack);
 };