[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel withTabModel:(TabModel*)newTabModel method with an equivalent construct that does not pass pointers to pointers to objc objects. Feel free to suggest a better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in blocks
* In tab_model_snapshot.mm, added a bridge cast. I'm not sure if this should be a conversion to std::string, because std::stringstream.operator<<(NSString*) can be both.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2810193002
Cr-Commit-Position: refs/heads/master@{#468652}
Committed: https://chromium.googlesource.com/chromium/src/+/9d30c08f5979bb312459afee2871e74a5b43d094

[stkhapugin, 2017-04-12 13:09:26]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 13:09:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-12 13:17:02]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel
withTabModel:(TabModel*)newTabModel method with an equivalent construct that
does not pass pointers to pointers to objc objects. Feel free to suggest a
better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in
blocks


BUG=624363
TEST=None
==========

[commit-bot: I haz the power, 2017-04-12 14:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 14:15:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-04-13 17:07:29]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel
withTabModel:(TabModel*)newTabModel method with an equivalent construct that
does not pass pointers to pointers to objc objects. Feel free to suggest a
better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in
blocks


BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel
withTabModel:(TabModel*)newTabModel method with an equivalent construct that
does not pass pointers to pointers to objc objects. Feel free to suggest a
better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in
blocks
* In tab_model_snapshot.mm, added a bridge cast. I'm not sure if this should be
a conversion to std::string, because std::stringstream.operator<<(NSString*) can
be both.

BUG=624363
TEST=None
==========

[stkhapugin, 2017-04-13 17:07:34]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 17:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:15:30]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-05-02 13:49:44]

stkhapugin@chromium.org changed reviewers:
+ jif@chromium.org

[stkhapugin, 2017-05-02 13:49:44]

PTAL

[sdefresne, 2017-05-02 14:23:11]

drive-by

https://codereview.chromium.org/2810193002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm (right):

https://codereview.chromium.org/2810193002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm:39: ss << (__bridge
void*)tab.tabId << std::endl
This should be "base::SysNSStringToUTF8(tab.tabId)".

[jif, 2017-05-02 14:33:21]

lgtm, just do what sylvain said

[stkhapugin, 2017-05-02 14:40:29]

Thank you!

https://codereview.chromium.org/2810193002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm (right):

https://codereview.chromium.org/2810193002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm:39: ss << (__bridge
void*)tab.tabId << std::endl
On 2017/05/02 14:23:11, sdefresne wrote:
> This should be "base::SysNSStringToUTF8(tab.tabId)".

Done.

[stkhapugin, 2017-05-02 14:41:21]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-05-02 14:41:22]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2810193002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-05-02 14:41:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:00:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493736081480840,
"parent_rev": "be86e8abc1a85b3cdb7b575ed1f5d6a6bbbfd460", "commit_rev":
"9d30c08f5979bb312459afee2871e74a5b43d094"}

[commit-bot: I haz the power, 2017-05-02 16:00:41]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel
withTabModel:(TabModel*)newTabModel method with an equivalent construct that
does not pass pointers to pointers to objc objects. Feel free to suggest a
better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in
blocks
* In tab_model_snapshot.mm, added a bridge cast. I'm not sure if this should be
a conversion to std::string, because std::stringstream.operator<<(NSString*) can
be both.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:tab_switcher to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Replaced 2 instances of replaceOldTabModel:(TabModel**)oldTabModel
withTabModel:(TabModel*)newTabModel method with an equivalent construct that
does not pass pointers to pointers to objc objects. Feel free to suggest a
better way that I can implement in a follow-up CL.
* some weak pointer dereferencing replaced with strong pointer dereferencing in
blocks
* In tab_model_snapshot.mm, added a bridge cast. I'm not sure if this should be
a conversion to std::string, because std::stringstream.operator<<(NSString*) can
be both.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2810193002
Cr-Commit-Position: refs/heads/master@{#468652}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d30c08f5979bb312459afee2871...
==========

[commit-bot: I haz the power, 2017-05-02 16:00:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d30c08f5979bb312459afee2871...