Record the parallel download UMA for fresh new downloads

Record the parallel download UMA for fresh new downloads

Start() can be called on both resumption and fresh new download
This CL records only the parallel downloads that are new

BUG=644352
Review-Url: https://codereview.chromium.org/2810133003
Cr-Commit-Position: refs/heads/master@{#464278}
Committed: https://chromium.googlesource.com/chromium/src/+/10603e265ae3928a1d9ea44470d82976d001bd3b

[qinmin, 2017-04-12 19:27:59]

qinmin@chromium.org changed reviewers:
+ xingliu@chromium.org

[qinmin, 2017-04-12 19:27:59]

PTAL

[xingliu, 2017-04-12 21:37:40]

https://codereview.chromium.org/2810133003/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl.cc (right):

https://codereview.chromium.org/2810133003/diff/1/content/browser/download/do...
content/browser/download/download_item_impl.cc:1284: if (state_ ==
INITIAL_INTERNAL && job_->UsesParallelRequests())
Should we remove the state_ check here?

Since it seems START_COUNT and NEW_DOWNLOAD_COUNT are recording the same number.
Maybe START_COUNT is also for resumption.

[qinmin, 2017-04-12 22:32:55]

https://codereview.chromium.org/2810133003/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl.cc (right):

https://codereview.chromium.org/2810133003/diff/1/content/browser/download/do...
content/browser/download/download_item_impl.cc:1284: if (state_ ==
INITIAL_INTERNAL && job_->UsesParallelRequests())
On 2017/04/12 21:37:39, xingliu wrote:
> Should we remove the state_ check here?
> 
> Since it seems START_COUNT and NEW_DOWNLOAD_COUNT are recording the same
number.
> Maybe START_COUNT is also for resumption.

Yes, we should, since NEW_DOWNLOAD_COUNT enum is added, we should make this the
same when recording download resumption/starts.

[xingliu, 2017-04-12 22:36:24]

lgtm

[qinmin, 2017-04-12 23:13:00]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:33:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492038780980210,
"parent_rev": "fe082ad7888c2d6685a0b857c525a69453e14e0a", "commit_rev":
"10603e265ae3928a1d9ea44470d82976d001bd3b"}

[commit-bot: I haz the power, 2017-04-13 03:34:40]

Description was changed from

==========
Record the parallel download UMA for fresh new downloads

Start() can be called on both resumption and fresh new download
This CL records only the parallel downloads that are new

BUG=644352
==========

to

==========
Record the parallel download UMA for fresh new downloads

Start() can be called on both resumption and fresh new download
This CL records only the parallel downloads that are new

BUG=644352

Review-Url: https://codereview.chromium.org/2810133003
Cr-Commit-Position: refs/heads/master@{#464278}
Committed:
https://chromium.googlesource.com/chromium/src/+/10603e265ae3928a1d9ea44470d8...
==========

[commit-bot: I haz the power, 2017-04-13 03:34:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/10603e265ae3928a1d9ea44470d8...