Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2810073002: Blink Rename follow-up: URLs --big-rename--> _ur_ls --this-fix--> _urls. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tzik, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, devtools-reviews_chromium.org, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, nhiroki, haraken, michaeln, shimazu+serviceworker_chromium.org, ajuma+watch-canvas_chromium.org, serviceworker-reviews, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org, kouhei (in TOK)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Rename follow-up: URLs --big-rename--> _ur_ls --this-fix--> _urls. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2810073002 Cr-Commit-Position: refs/heads/master@{#464252} Committed: https://chromium.googlesource.com/chromium/src/+/88f78352fa3d325662153e2a1e50f46cccce1303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/PublicURLManager.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Łukasz Anforowicz
dcheng@, could you PTAL?
3 years, 8 months ago (2017-04-11 20:17:46 UTC) #4
dcheng
LGTM
3 years, 8 months ago (2017-04-11 21:37:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810073002/1
3 years, 8 months ago (2017-04-11 21:44:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/408453)
3 years, 8 months ago (2017-04-11 21:56:21 UTC) #10
Łukasz Anforowicz
imcheng@ and falken@ - can you PTAL at third_party/WebKit/Source/modules?
3 years, 8 months ago (2017-04-11 22:01:19 UTC) #12
Łukasz Anforowicz
+kouhei@ to CC - thanks for fixing the other cases of this problem :-) [and ...
3 years, 8 months ago (2017-04-11 22:02:32 UTC) #13
imcheng
third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp lgtm
3 years, 8 months ago (2017-04-12 00:40:31 UTC) #14
kouhei (in TOK)
core lgtm
3 years, 8 months ago (2017-04-12 01:34:34 UTC) #16
falken
lgtm apologies for delay
3 years, 8 months ago (2017-04-13 00:12:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810073002/1
3 years, 8 months ago (2017-04-13 00:42:01 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:33:38 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88f78352fa3d325662153e2a1e50...

Powered by Google App Engine
This is Rietveld 408576698