DescriptionReland of Fetch ARC Kiosk app name and icon from Android side. (patchset #1 id:1 of https://codereview.chromium.org/2810973004/ )
Reason for revert:
Fix memory leak and re-land.
Original issue's description:
> Revert of Fetch ARC Kiosk app name and icon from Android side. (patchset #13 id:240001 of https://codereview.chromium.org/2778053002/ )
>
> Reason for revert:
> Appears to have broken the following tests on Ubuntu 14.04 memory bot:
>
> KioskUpdateTest.LaunchOfflineEnabledAppNoUpdate
> KioskUpdateTest.LaunchCachedNewVersionOfflineEnabledAppNoNetwork
> KioskUpdateTest.UpdateAppWithSharedModuleRemoveAllSecondaryApps
> KioskUpdateTest.UpdateMultiAppKioskRemoveOneApp
> KioskUpdateTest.LaunchOfflineEnabledAppNoNetwork
> KioskUpdateTest.UpdateMultiAppKioskAddOneApp
> KioskUpdateTest.PRE_IncompliantPlatformDelayInstall
> KioskUpdateTest.LaunchCachedOfflineEnabledAppNoNetwork
> KioskUpdateTest.PreserveLocalData
> KioskUpdateTest.PermissionChange
> KioskAppManagerTest.GetAutoLaunchAppRequiredPlatformVersion
> KioskAppManagerTest.IsPlatformCompliantWithApp
> KioskUpdateTest.LaunchAppWithUpdatedModule
> KioskAppManagerTest.UpdateAppDataFromProfile
> KioskUpdateTest.LaunchOfflineEnabledAppHasUpdate
> KioskAppManagerTest.ClearAppData
> KioskUpdateTest.UsbStickUpdateAppNoNetwork
> KioskAppManagerTest.UpdateAppDataFromCrx
> KioskAppManagerTest.LoadCached
> KioskTest.LaunchAppNetworkDown
>
> http://uberchromegw/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/20548
>
> Original issue's description:
> > Fetch ARC Kiosk app name and icon from Android side.
> >
> > To provide appropriate and up-to-date app name and icon
> > for ARC Kiosk apps on sign in screen, this data is updated from
> > ARC side when Android container contains information about them,
> > i.e.apps are installed in ARC Kiosk session.
> > Before that name is provided by DMServer and default icon is used.
> >
> > ArcKioskAppData is extended from simple structure to a class,
> > which caches the data from above to be used on sign in screen.
> >
> > IconLoader from KioskAppData is extracted as general
> > KioskAppIconLoader for both Chrome and ARC apps.
> >
> > BUG=679928
> > TEST=Manual
> >
> > Review-Url: https://codereview.chromium.org/2778053002
> > Cr-Commit-Position: refs/heads/master@{#463607}
> > Committed: https://chromium.googlesource.com/chromium/src/+/a5709293688a27bb196e33b9488193012f653f63
>
> TBR=khmel@chromium.org,xiyuan@chromium.org,lhchavez@chromium.org,poromov@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=679928
>
> Review-Url: https://codereview.chromium.org/2810973004
> Cr-Commit-Position: refs/heads/master@{#463648}
> Committed: https://chromium.googlesource.com/chromium/src/+/8150e6af3dc7dead6b5f1a126bede6064036b43a
TBR=khmel@chromium.org,xiyuan@chromium.org,lhchavez@chromium.org,rouslan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679928
Review-Url: https://codereview.chromium.org/2810053003
Cr-Commit-Position: refs/heads/master@{#464004}
Committed: https://chromium.googlesource.com/chromium/src/+/8a4add0c160a539fba0a3ddd47b7d2b05d0d5e4d
Patch Set 1 #Patch Set 2 : fix memory leak, reland the CL #Messages
Total messages: 11 (7 generated)
|