Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2810033002: MD Settings: Always scroll to section when navigating from About section (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 9250fd23b90cb69d34ea3dc2db0cdc564a234061..6983546cefafa7429188c946682390539963ffc3 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -80,9 +80,10 @@ var MainPageBehaviorImpl = {
// Scroll to the section except for back/forward. Also scroll for any
// in-page back/forward navigations (from a section or the root page).
- var scrollToSection =
- !settings.lastRouteChangeWasPopstate() || oldRouteWasSection ||
- oldRoute == settings.Route.BASIC;
+ // Also always scroll when coming from either the About or root page.
+ var scrollToSection = !settings.lastRouteChangeWasPopstate() ||
+ oldRouteWasSection || oldRoute == settings.Route.BASIC ||
+ oldRoute == settings.Route.ABOUT;
if (oldRoute && (oldRoute.isSubpage() || newRoute.isSubpage()))
this.isSubpageAnimating = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698