Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2810033002: MD Settings: Always scroll to section when navigating from About section (Closed)

Created:
3 years, 8 months ago by tommycli
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Always scroll to section when navigating from About section BUG=706717 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2810033002 Cr-Commit-Position: refs/heads/master@{#463803} Committed: https://chromium.googlesource.com/chromium/src/+/1f1f1030179680191dfbfc9e708474ce4ebb7301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tommycli
dpapad: PTAL tiny one, thanks!
3 years, 8 months ago (2017-04-11 18:46:36 UTC) #5
Dan Beam
🙈 lgtm 🙈
3 years, 8 months ago (2017-04-11 18:54:40 UTC) #7
dpapad
lgtm
3 years, 8 months ago (2017-04-11 18:57:40 UTC) #8
tommycli
On 2017/04/11 18:57:40, dpapad wrote: > lgtm thanks all!
3 years, 8 months ago (2017-04-11 21:29:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810033002/1
3 years, 8 months ago (2017-04-11 21:29:51 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 22:29:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f1f1030179680191dfbfc9e7084...

Powered by Google App Engine
This is Rietveld 408576698