Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2809993003: ServerSetDoNotFragment skip IPv6 on ERR_ADDRESS_UNREACHABLE. (Closed)

Created:
3 years, 8 months ago by mbjorge
Modified:
3 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change UDPSocketTest.ServerSetDoNotFragment to ignore ERR_ADDRESS_UNREACHABLE errors when binding to IPv6. BUG=710572 Review-Url: https://codereview.chromium.org/2809993003 Cr-Commit-Position: refs/heads/master@{#464140} Committed: https://chromium.googlesource.com/chromium/src/+/58d40e4d8570ce25575e42709c6b534124a99612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/socket/udp_socket_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mbjorge
3 years, 8 months ago (2017-04-11 19:44:21 UTC) #2
Ryan Hamilton
lgtm, but can you change the description to something a bit more readable like: Change ...
3 years, 8 months ago (2017-04-12 04:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809993003/1
3 years, 8 months ago (2017-04-12 17:58:06 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:44:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58d40e4d8570ce25575e42709c6b...

Powered by Google App Engine
This is Rietveld 408576698