Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2809973002: Add README.md for //build/android/incremental_install (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add README.md for //build/android/incremental_install Review-Url: https://codereview.chromium.org/2809973002 Cr-Commit-Position: refs/heads/master@{#463747} Committed: https://chromium.googlesource.com/chromium/src/+/2b6b927cc9cf4442b160da02285ae62613f90d5f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
A build/android/incremental_install/README.md View 1 chunk +81 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
On 2017/04/11 15:57:35, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:shenghuazhang@chromium.org 🚒
3 years, 8 months ago (2017-04-11 15:57:49 UTC) #2
shenghuazhang
lgtm It's nice to have this! Thanks Andrew
3 years, 8 months ago (2017-04-11 17:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809973002/1
3 years, 8 months ago (2017-04-11 19:53:22 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-11 19:53:23 UTC) #7
jbudorick
lgtm w/ q https://codereview.chromium.org/2809973002/diff/1/build/android/incremental_install/README.md File build/android/incremental_install/README.md (right): https://codereview.chromium.org/2809973002/diff/1/build/android/incremental_install/README.md#newcode12 build/android/incremental_install/README.md:12: incremental_apk_by_default = true Do the indents ...
3 years, 8 months ago (2017-04-11 19:56:45 UTC) #9
agrieve
https://codereview.chromium.org/2809973002/diff/1/build/android/incremental_install/README.md File build/android/incremental_install/README.md (right): https://codereview.chromium.org/2809973002/diff/1/build/android/incremental_install/README.md#newcode12 build/android/incremental_install/README.md:12: incremental_apk_by_default = true On 2017/04/11 19:56:45, jbudorick wrote: > ...
3 years, 8 months ago (2017-04-11 20:02:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809973002/1
3 years, 8 months ago (2017-04-11 20:03:50 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 20:20:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b6b927cc9cf4442b160da02285a...

Powered by Google App Engine
This is Rietveld 408576698