Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2809963004:
For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64. (Closed)
DescriptionFor building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE).
Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/
Chromium_BUG=706728
R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org
Review-Url: https://codereview.chromium.org/2809963004
Cr-Commit-Position: refs/heads/master@{#45268}
Committed: https://chromium.googlesource.com/v8/v8/+/468f1958e01b80bacd61bff809bfae4312d45e3e
Patch Set 1 #
Total comments: 3
Patch Set 2 : removed the changes in mb_config.pyl #Patch Set 3 #Patch Set 4 : rebased, uses host_byteorder.gni now #
Messages
Total messages: 43 (33 generated)
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64. Also add support for host byteorder logic. Work in progress. Related to the chromium_Issues=2815453004, 2812173002 BUG=706728 ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64. Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, agrieve@chromium.org BUG=706728 ==========
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64. Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, agrieve@chromium.org BUG=706728 ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, agrieve@chromium.org BUG=706728 ==========
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, agrieve@chromium.org BUG=706728 ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org BUG=706728 ==========
rayb@ca.ibm.com changed reviewers: + adamk@chromium.org, dpranke@chromium.org, machenbach@chromium.org
ptal
The GN and MB changes lgtm, but I"m not a committer so you still need machenbach or adamk to review as well.
lgtm with comment: Please wait 2-3 days until after the chromium CL has propagated into our DEPS. https://codereview.chromium.org/2809963004/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2809963004/diff/1/infra/mb/mb_config.pyl#newc... infra/mb/mb_config.pyl:69: 'V8 Aix64': 'gn_release_ppc64', Please do the mb_config.pyl change in a separate CL. After the gn support CL lands, we can check for flag differences on the bots in: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20ppc64%... You should also switch the beta/stable bots in the same CL and remove the corresponding gyp config. The bots will first really switch when the CL propagates to the branch.
https://codereview.chromium.org/2809963004/diff/1/BUILD.gn File BUILD.gn (left): https://codereview.chromium.org/2809963004/diff/1/BUILD.gn#oldcode122 BUILD.gn:122: } I think we should leave this here, at least until we have a need for host_byteorder somewhere outside of v8. If we have that need at that time, we should start by creating a separate host_byteorder.gni file, rather than setting it in BUILDCONFIG. We should avoid changes to BUILDCONFIG if at all possible.
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org BUG=706728 ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org ==========
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ Chromium_BUG=706728 R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org ==========
ptal. Also updated the three related cls - https://codereview.chromium.org/2807463004/ https://codereview.chromium.org/2815453004/ https://codereview.chromium.org/2812173002/ https://codereview.chromium.org/2809963004/diff/1/BUILD.gn File BUILD.gn (left): https://codereview.chromium.org/2809963004/diff/1/BUILD.gn#oldcode122 BUILD.gn:122: } On 2017/04/18 20:31:35, Dirk Pranke wrote: > I think we should leave this here, at least until we have a need for > host_byteorder somewhere outside of v8. > > If we have that need at that time, we should start by creating a separate > host_byteorder.gni file, rather than setting it in BUILDCONFIG. We should avoid > changes to BUILDCONFIG if at all possible. As per the discussion on the other CL, we now use host_byteorder.gni to get the host_byteorder.
lgtm
The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/24918) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/21515) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
The CQ bit was unchecked by rayb@ca.ibm.com
The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rayb@ca.ibm.com
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2809963004/#ps60001 (title: "rebased, uses host_byteorder.gni now")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rayb@ca.ibm.com
The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rayb@ca.ibm.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494552804420870,
"parent_rev": "74543fedd8dcef8c5963c5779010e73358467eed", "commit_rev":
"468f1958e01b80bacd61bff809bfae4312d45e3e"}
Message was sent while issue was closed.
Description was changed from ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ Chromium_BUG=706728 R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org ========== to ========== For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ Chromium_BUG=706728 R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/2809963004 Cr-Commit-Position: refs/heads/master@{#45268} Committed: https://chromium.googlesource.com/v8/v8/+/468f1958e01b80bacd61bff809bfae4312d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/468f1958e01b80bacd61bff809bfae4312d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
