Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: content/browser/tracing/etw_tracing_agent_win.cc

Issue 2809933003: Remove ListValue::Append(raw ptr) on Win (Closed)
Patch Set: More Win Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/etw_tracing_agent_win.cc
diff --git a/content/browser/tracing/etw_tracing_agent_win.cc b/content/browser/tracing/etw_tracing_agent_win.cc
index 4392084d2b32f2e2b8b016820466401a5d5f29dc..d24b4b63f5c3d322a14aa981b5c318ce9e05717f 100644
--- a/content/browser/tracing/etw_tracing_agent_win.cc
+++ b/content/browser/tracing/etw_tracing_agent_win.cc
@@ -6,6 +6,8 @@
#include <stdint.h>
+#include <utility>
+
#include "base/base64.h"
#include "base/json/json_string_value_serializer.h"
#include "base/lazy_instance.h"
@@ -174,7 +176,7 @@ void EtwTracingAgent::AddSyncEventToBuffer() {
"%08X%08X", now_in_us.HighPart, now_in_us.LowPart)));
// Append it to the events buffer.
- events_->Append(value.release());
+ events_->Append(std::move(value));
}
void EtwTracingAgent::AppendEventToBuffer(EVENT_TRACE* event) {
@@ -204,7 +206,7 @@ void EtwTracingAgent::AppendEventToBuffer(EVENT_TRACE* event) {
value->Set("payload", new base::Value(payload));
// Append it to the events buffer.
- events_->Append(value.release());
+ events_->Append(std::move(value));
}
void EtwTracingAgent::TraceAndConsumeOnThread() {
@@ -228,7 +230,7 @@ void EtwTracingAgent::FlushOnThread(
header->Set("name", new base::Value("ETW"));
// Release and pass the events buffer.
- header->Set("content", events_.release());
+ header->Set("content", std::move(events_));
// Serialize the results as a JSon string.
std::string output;

Powered by Google App Engine
This is Rietveld 408576698