Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2809923004: AnalyserNode.channelCount should be 1 (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

AnalyserNode.channelCount should be 1 The spec says channelCount should be 1. Also change the default number of output channels to be 1 (was 2). This reduces complexity of any down-stream nodes so that they will process mono unless the input to the AnalyserNode has more than one channel. Without this, all down-stream nodes will see a stereo input, doubling processing costs. This change should not be user-detectable in any way. BUG=706610 TEST=constructor/analyser.html Review-Url: https://codereview.chromium.org/2809923004 Cr-Commit-Position: refs/heads/master@{#466787} Committed: https://chromium.googlesource.com/chromium/src/+/2dbd3497a559c2227a37a4e108f6380394c049a4

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-24 16:17:21 UTC) #3
hongchan
lgtm
3 years, 8 months ago (2017-04-24 20:59:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809923004/20001
3 years, 8 months ago (2017-04-24 21:06:43 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:06:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2dbd3497a559c2227a37a4e108f6...

Powered by Google App Engine
This is Rietveld 408576698