Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2809913004: Revert of Remove unneeded calls to plugin.SetParentVisible. (Closed)

Created:
3 years, 8 months ago by joelhockey
Modified:
3 years, 8 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unneeded calls to plugin.SetParentVisible. (patchset #3 id:40001 of https://codereview.chromium.org/2808723002/ ) Reason for revert: Although no tests failed from this change, and it seems that pepper plugins do nothing for visibility changes: https://cs.chromium.org/chromium/src/content/renderer/pepper/pepper_webplugin_impl.cc?l=206&rcl=0cc4c62a163318c06636916b7e2b2c6a56f16b74 I think that this is still important for browser_plugin: https://cs.chromium.org/chromium/src/content/renderer/browser_plugin/browser_plugin.cc?l=427&rcl=b6dc62f53d4c3b14c0f541897f8d2970be89b84b Original issue's description: > Remove unneeded calls to plugin.SetParentVisible. > > Plugin (WebPluginContainerImpl) does not keep its own state about > visibility of parent, and once it is no longer inheriting from > FrameViewBase, it will not implement any ParentVisible methods. > If required, it could always call parent_.IsVisible. > > BUG=637460 > > Review-Url: https://codereview.chromium.org/2808723002 > Cr-Commit-Position: refs/heads/master@{#463409} > Committed: https://chromium.googlesource.com/chromium/src/+/e62eb16ec0d97fe0b59d39e3c5f9c0669e6d9cff TBR=dcheng@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637460 Review-Url: https://codereview.chromium.org/2809913004 Cr-Commit-Position: refs/heads/master@{#463953} Committed: https://chromium.googlesource.com/chromium/src/+/db77d9c68e2df6c5d5c626455a19d9a1aef76598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
joelhockey
Created Revert of Remove unneeded calls to plugin.SetParentVisible.
3 years, 8 months ago (2017-04-12 04:34:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809913004/1
3 years, 8 months ago (2017-04-12 04:34:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-12 04:34:40 UTC) #5
haraken
LGTM
3 years, 8 months ago (2017-04-12 04:37:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809913004/1
3 years, 8 months ago (2017-04-12 04:53:38 UTC) #8
dcheng
lgtm
3 years, 8 months ago (2017-04-12 06:39:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809913004/1
3 years, 8 months ago (2017-04-12 07:15:57 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 07:59:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db77d9c68e2df6c5d5c626455a19...

Powered by Google App Engine
This is Rietveld 408576698