Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2809853003: Revert of [sync] Fix decryption failure caused by missing user_key (Closed)

Created:
3 years, 8 months ago by Patrick Noland
Modified:
3 years, 8 months ago
Reviewers:
skym, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sync] Fix decryption failure caused by missing user_key (patchset #2 id:40001 of https://codereview.chromium.org/2813453004/ ) Reason for revert: Causing crashes on all platforms Original issue's description: > [sync] Fix decryption failure caused by missing user_key > > Recently, a change removed code that populated the user_key field of > nigori nodes. Clients running code from before this change fail to > import keys that don't have user_key populated. If a post-change > client commits a nigori node, a pre-change client will fail to > subsequently import it. > This change restores code that populates user_key, but omits code > that fails the import if the user_key is absent. > > R=pavely@chromium.org > BUG=707967 > > Review-Url: https://codereview.chromium.org/2813453004 > Cr-Commit-Position: refs/heads/master@{#463455} > Committed: https://chromium.googlesource.com/chromium/src/+/399458cbfa1d8458842e9119e6ad063716c7e66e TBR=pavely@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707967 Review-Url: https://codereview.chromium.org/2809853003 Cr-Commit-Position: refs/heads/master@{#463655} Committed: https://chromium.googlesource.com/chromium/src/+/0dd660b9ba6e4699468c635874da841a25e135a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -69 lines) Patch
M components/sync/base/cryptographer.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M components/sync/base/nigori.h View 3 chunks +2 lines, -11 lines 0 comments Download
M components/sync/base/nigori.cc View 3 chunks +5 lines, -17 lines 0 comments Download
M components/sync/base/nigori_unittest.cc View 2 chunks +2 lines, -28 lines 0 comments Download
M components/sync/engine_impl/model_type_worker_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Patrick Noland
Created Revert of [sync] Fix decryption failure caused by missing user_key
3 years, 8 months ago (2017-04-11 16:43:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809853003/1
3 years, 8 months ago (2017-04-11 16:43:31 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-11 16:43:32 UTC) #5
skym
lgtm
3 years, 8 months ago (2017-04-11 16:44:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809853003/1
3 years, 8 months ago (2017-04-11 16:45:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 16:47:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0dd660b9ba6e4699468c635874da...

Powered by Google App Engine
This is Rietveld 408576698