Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2809853002: Removes constant for Google Spaces app (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
Reviewers:
jif, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes constant for Google Spaces app This is part of the revert of https://chromereviews.googleplex.com/426447013/ This CL depends on https://chromereviews.googleplex.com/578437015 and should not be submitted until it has been submitted. BUG=708607 TEST=Go to Settings and check that Google Spaces is no longer listed. Review-Url: https://codereview.chromium.org/2809853002 Cr-Commit-Position: refs/heads/master@{#463587} Committed: https://chromium.googlesource.com/chromium/src/+/a18f1349f3a93817a44f6a5cdca13aca485a2df7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ios/chrome/browser/native_app_launcher/ios_appstore_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/native_app_launcher/ios_appstore_ids.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pkl (ping after 24h if needed)
3 years, 8 months ago (2017-04-10 23:47:34 UTC) #3
lpromero
lgtm
3 years, 8 months ago (2017-04-11 08:26:55 UTC) #4
lpromero
lgtm Downstream was pushed.
3 years, 8 months ago (2017-04-11 09:11:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809853002/1
3 years, 8 months ago (2017-04-11 09:11:48 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 09:28:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a18f1349f3a93817a44f6a5cdca1...

Powered by Google App Engine
This is Rietveld 408576698