Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/sync_driver/non_blocking_data_type_controller_unittest.cc

Issue 280983002: Implement sync in the NonBlockingTypeProcessor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add some expectations on non_unique_name Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/model_thread_sync_entity.h » ('j') | sync/engine/model_thread_sync_entity.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/non_blocking_data_type_controller_unittest.cc
diff --git a/components/sync_driver/non_blocking_data_type_controller_unittest.cc b/components/sync_driver/non_blocking_data_type_controller_unittest.cc
index 32e475ff12f04c61b02e127b9d157779d40243eb..2c9076cec4daace0b9a9f53a84981882856bde41 100644
--- a/components/sync_driver/non_blocking_data_type_controller_unittest.cc
+++ b/components/sync_driver/non_blocking_data_type_controller_unittest.cc
@@ -12,12 +12,38 @@
#include "base/test/test_simple_task_runner.h"
#include "components/sync_driver/non_blocking_data_type_controller.h"
#include "sync/engine/non_blocking_type_processor.h"
+#include "sync/engine/non_blocking_type_processor_core_interface.h"
#include "sync/internal_api/public/base/model_type.h"
#include "sync/internal_api/public/sync_core_proxy.h"
#include "testing/gtest/include/gtest/gtest.h"
+namespace syncer {
+
+class NonBlockingTypeProcessorCore;
+
namespace {
+// A useless instance of NonBlockingTypeProcessorCore.
+class NullNonBlockingTypeProcessorCore
+ : public NonBlockingTypeProcessorCoreInterface {
+ public:
+ NullNonBlockingTypeProcessorCore();
+ virtual ~NullNonBlockingTypeProcessorCore();
+
+ virtual void RequestCommits(const CommitRequestDataList& list) OVERRIDE;
+};
+
+NullNonBlockingTypeProcessorCore::NullNonBlockingTypeProcessorCore() {
+}
+
+NullNonBlockingTypeProcessorCore::~NullNonBlockingTypeProcessorCore() {
+}
+
+void NullNonBlockingTypeProcessorCore::RequestCommits(
+ const CommitRequestDataList& list) {
+ NOTREACHED() << "Not implemented.";
+}
+
// A class that pretends to be the sync backend.
class MockSyncCore {
public:
@@ -28,10 +54,11 @@ class MockSyncCore {
enabled_types_.Put(type);
model_task_runner->PostTask(
FROM_HERE,
- base::Bind(&syncer::NonBlockingTypeProcessor::OnConnect,
- type_processor,
- base::WeakPtr<syncer::NonBlockingTypeProcessorCore>(),
- scoped_refptr<base::SequencedTaskRunner>()));
+ base::Bind(
+ &syncer::NonBlockingTypeProcessor::OnConnect,
+ type_processor,
+ base::Passed(scoped_ptr<NonBlockingTypeProcessorCoreInterface>(
+ new NullNonBlockingTypeProcessorCore()).Pass())));
}
void Disconnect(syncer::ModelType type) {
@@ -58,6 +85,7 @@ class MockSyncCoreProxy : public syncer::SyncCoreProxy {
virtual void ConnectTypeToCore(
syncer::ModelType type,
+ const DataTypeState& data_type_state,
base::WeakPtr<syncer::NonBlockingTypeProcessor> type_processor) OVERRIDE {
// Normally we'd use MessageLoopProxy::current() as the TaskRunner argument
// to Connect(). That won't work here in this test, so we use the
@@ -88,6 +116,8 @@ class MockSyncCoreProxy : public syncer::SyncCoreProxy {
scoped_refptr<base::TestSimpleTaskRunner> sync_task_runner_;
};
+} // namespace
+
class NonBlockingDataTypeControllerTest : public testing::Test {
public:
NonBlockingDataTypeControllerTest()
@@ -406,4 +436,4 @@ TEST_F(NonBlockingDataTypeControllerTest, EnableDisableEnableRace) {
EXPECT_TRUE(processor_.IsConnected());
}
-} // namespace
+} // namespace syncer
« no previous file with comments | « no previous file | sync/engine/model_thread_sync_entity.h » ('j') | sync/engine/model_thread_sync_entity.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698