Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2809803002: Fix a linker error when enable_webrtc is false on Android (Closed)

Created:
3 years, 8 months ago by AndyWu
Modified:
3 years, 8 months ago
CC:
braveyao, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a linker error when enable_webrtc is false on Android Linker complains an undefined reference to 'content::MediaStreamDispatcher::GetNonScreenCaptureDevices()' when building Cast for Android with enable_webrtc being false. BUG=Internal b/37205701 Review-Url: https://codereview.chromium.org/2809803002 Cr-Commit-Position: refs/heads/master@{#463420} Committed: https://chromium.googlesource.com/chromium/src/+/a86cde70ba2d0eee6c7d40b2ca7ace6ac2bf97e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
AndyWu
The issue was introduced from the CL: https://codereview.chromium.org/2763743002. It was guarded by ENABLE_WEBRTC before.
3 years, 8 months ago (2017-04-10 21:10:20 UTC) #3
aelias_OOO_until_Jul13
lgtm
3 years, 8 months ago (2017-04-10 21:18:49 UTC) #4
halliwell
On 2017/04/10 21:18:49, aelias wrote: > lgtm lgtm
3 years, 8 months ago (2017-04-10 21:24:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809803002/1
3 years, 8 months ago (2017-04-10 21:29:56 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:28:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a86cde70ba2d0eee6c7d40b2ca7a...

Powered by Google App Engine
This is Rietveld 408576698