Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document (Closed)
Patch Set: processingLoadEvent() as part of shouldComplete(), cleanup shouldComplete() Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
index bdf236c9e3545b1c9ec716f43358cf36b562d34d..ed5984104cc2b55c2f6604d779b19edad92abea4 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
@@ -637,6 +637,11 @@ TEST_F(FrameFetchContextTest, MainResourceCachePolicy) {
}
TEST_F(FrameFetchContextTest, SubResourceCachePolicy) {
+ // Reset load event state: if the load event is finished, we ignore the
+ // DocumentLoader load type.
+ document->open();
Nate Chapin 2017/04/11 23:25:50 This is needed because Document::CancelParsing() n
+ ASSERT_FALSE(document->LoadEventFinished());
+
// Default case
ResourceRequest request("http://www.example.com/mock");
EXPECT_EQ(WebCachePolicy::kUseProtocolCachePolicy,

Powered by Google App Engine
This is Rietveld 408576698