third_party/WebKit/Source/core/loader/FrameFetchContext.cpp - Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document (Closed)

Patch Set: processingLoadEvent() as part of shouldComplete(), cleanup shouldComplete() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

index ec6f92f5133370fd4c4e1363cd669515cdae0403..b5e7b5d95bf7df562944a2a7ef0ef7d920d0af11 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

@@ -627,10 +627,11 @@ void FrameFetchContext::RecordLoadingActivity(

}

void FrameFetchContext::DidLoadResource(Resource* resource) {

+ if (!document_)

+ return;

if (resource->IsLoadEventBlockingResourceType())

- GetFrame()->Loader().CheckCompleted();

- if (document_)

- FirstMeaningfulPaintDetector::From(*document_).CheckNetworkStable();

+ document_->CheckCompleted();

+ FirstMeaningfulPaintDetector::From(*document_).CheckNetworkStable();

}

void FrameFetchContext::AddResourceTiming(const ResourceTimingInfo& info) {