content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc - Issue 2809673002: Fix double close in MojoAudioOutputStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc

Issue 2809673002: Fix double close in MojoAudioOutputStream. (Closed)

Patch Set: Fix Win complie. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_renderer_host.cc ('K') | « content/browser/renderer_host/media/audio_sync_reader.cc ('k') | media/audio/audio_output_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc

diff --git a/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc b/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc

index 2e3f864930138de9d28b287cdf73af6fd3b902f6..23f3e82a4c14f483a044d072b3d278949c98b0b7 100644

--- a/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc

+++ b/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc

@@ -239,9 +239,11 @@ TEST(RenderFrameAudioOutputStreamFactoryTest, CreateStream) {

base::SharedMemory shared_memory;

ASSERT_TRUE(shared_memory.CreateAndMapAnonymous(100));

- base::CancelableSyncSocket local, remote;

- ASSERT_TRUE(base::CancelableSyncSocket::CreatePair(&local, &remote));

- event_handler->OnStreamCreated(kStreamId, &shared_memory, &remote);

+ auto local = base::MakeUnique<base::CancelableSyncSocket>();

+ auto remote = base::MakeUnique<base::CancelableSyncSocket>();

+ ASSERT_TRUE(

+ base::CancelableSyncSocket::CreatePair(local.get(), remote.get()));

+ event_handler->OnStreamCreated(kStreamId, &shared_memory, std::move(remote));

base::RunLoop().RunUntilIdle();

// Make sure we got the callback from creating stream.