Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 2809673002: Fix double close in MojoAudioOutputStream. (Closed)
Patch Set: Fix Win complie. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 2c79886dcc9177a5998c3410a73fca124e6eb05e..5579d0503969819d483822397bd80751419e3deb 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -107,7 +107,7 @@ void AudioRendererHost::OnDestruct() const {
void AudioRendererHost::OnStreamCreated(
int stream_id,
base::SharedMemory* shared_memory,
- base::CancelableSyncSocket* foreign_socket) {
+ std::unique_ptr<base::CancelableSyncSocket> foreign_socket) {
DaleCurtis 2017/04/11 18:22:44 You need something to own this here now or the soc
Max Morin 2017/04/12 08:16:06 It's fine to close the socket handle on this end,
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!PeerHandle()) {
« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host.h ('k') | content/browser/renderer_host/media/audio_sync_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698