Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: BUILD.gn

Issue 2809653003: Introduce mkgrokdump to update tools/v8heapconst.py. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Makefile » ('j') | test/v8heapconst/testcfg.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8daba55e4d6847575df44f16e2387819a3926b88..7d36a214cd73fdb7c56b680c1eae404b89b0b012 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -142,6 +142,7 @@ if (v8_enable_v8_checks == "") {
is_target_simulator = target_cpu != v8_target_cpu
v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
+v8_generated_heap_constants = "$target_gen_dir/v8heapconst.py"
v8_random_seed = "314159265"
v8_toolset_for_shell = "host"
@@ -2666,6 +2667,28 @@ v8_executable("mkpeephole") {
]
}
+v8_executable("mkgrokdump") {
Michael Achenbach 2017/04/11 09:45:54 Note that due to GN's nature, this target will be
Yang 2017/04/11 09:57:20 Acknowledged.
+ # mkgrokdump is used to create tools/v8heapconst.py.
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+
+ sources = [
+ "tools/mkgrokdump.cc",
+ ]
+
+ configs = [
+ ":external_config",
+ ":internal_config",
+ ]
+
+ deps = [
+ ":v8",
+ ":v8_libbase",
+ ":v8_libplatform",
+ "//build/config/sanitizers:deps",
+ "//build/win:default_exe_manifest",
+ ]
+}
+
###############################################################################
# Public targets
#
« no previous file with comments | « no previous file | Makefile » ('j') | test/v8heapconst/testcfg.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698