Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2809633002: Add curly brackets to list of characters that gn needs to escape (Closed)

Created:
3 years, 8 months ago by Olle Liljenzin
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add curly brackets to list of characters that gn needs to escape Curly brackets {} needs to be escaped to avoid brace expansion on systems using bash as the default shell. BUG=709934 Review-Url: https://codereview.chromium.org/2809633002 Cr-Commit-Position: refs/heads/master@{#466286} Committed: https://chromium.googlesource.com/chromium/src/+/7fd3f6718896969f1a5d3850a6d81f4ccf74abd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/gn/escape.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/escape_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Olle Liljenzin
3 years, 8 months ago (2017-04-10 12:29:07 UTC) #2
Olle Liljenzin
brettw, could you please have a look at the patch? I found no other names ...
3 years, 8 months ago (2017-04-19 07:31:02 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-04-20 17:14:24 UTC) #4
brettw
Sorry for taking so long!
3 years, 8 months ago (2017-04-20 17:15:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809633002/1
3 years, 8 months ago (2017-04-21 07:43:26 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 07:46:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fd3f6718896969f1a5d3850a6d8...

Powered by Google App Engine
This is Rietveld 408576698