Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 28096: Merge 10246 - Fixes issue with download shelf not warning on .exe files... (Closed)

Created:
11 years, 10 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge 10246 - Fixes issue with download shelf not warning on .exe files Make download manager treat mixed-case extensions the same as lower-case extensions when judging whether a file is executable. Also, store known executable file extensions as narrow strings since they are all ASCII anyway. r=jcampan BUG=7455 Review URL: http://codereview.chromium.org/29003 TBR=estade Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -87 lines) Patch
M chrome/browser/download/download_exe.cc View 1 chunk +84 lines, -84 lines 0 comments Download
M chrome/browser/download/download_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698