Make download manager treat mixed-case extensions the same as lower-case exte...

Make download manager treat mixed-case extensions the same as lower-case extensions when judging whether a file is executable.

Also, store known executable file extensions as narrow strings since they are all ASCII anyway.

r=jcampan
BUG=7455
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10246

[jcampan, 2009-02-24 01:05:39]

http://codereview.chromium.org/29003/diff/1007/12
File chrome/browser/download/download_exe.cc (right):

http://codereview.chromium.org/29003/diff/1007/12#newcode68
Line 68: "cp",
It seems you removed by mistake ending Ls in some of the extension.

[Evan Stade, 2009-02-24 01:12:18]

good catch

http://codereview.chromium.org/29003/diff/1007/12
File chrome/browser/download/download_exe.cc (right):

http://codereview.chromium.org/29003/diff/1007/12#newcode68
Line 68: "cp",
On 2009/02/24 01:05:39, jcampan wrote:
> It seems you removed by mistake ending Ls in some of the extension.

oh drat. Case insensitive find/replace. Fixed.

[tony, 2009-02-24 01:25:37]

It would be nice if there was a test for this.  Could be in a follow up change.

On 2009/02/24 01:12:18, estade wrote:
> good catch
> 
> http://codereview.chromium.org/29003/diff/1007/12
> File chrome/browser/download/download_exe.cc (right):
> 
> http://codereview.chromium.org/29003/diff/1007/12#newcode68
> Line 68: "cp",
> On 2009/02/24 01:05:39, jcampan wrote:
> > It seems you removed by mistake ending Ls in some of the extension.
> 
> oh drat. Case insensitive find/replace. Fixed.

[jcampan, 2009-02-24 02:05:54]

LGTM