Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 2809583002: Use off-heap data for type feedback in PolymorphicInstanceCallInstr (Closed)
Patch Set: More feedback from Slava Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index f3a39c19d29740641be972bd1c940763d5fa0e75..c44dc66cb5262923ca7c92f55fed24541f21b519 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -3139,8 +3139,12 @@ class CheckedSmiSlowPath : public SlowPathCode {
}
__ Push(locs->in(0).reg());
__ Push(locs->in(1).reg());
+ const String& selector =
+ String::Handle(instruction_->call()->ic_data()->target_name());
+ const Array& argument_names =
+ Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
compiler->EmitMegamorphicInstanceCall(
- *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(),
+ selector, argument_names, instruction_->call()->ArgumentCount(),
instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
locs, try_index_,
/* slow_path_argument_count = */ 2);
@@ -3278,8 +3282,12 @@ class CheckedSmiComparisonSlowPath : public SlowPathCode {
}
__ Push(locs->in(0).reg());
__ Push(locs->in(1).reg());
+ String& selector =
+ String::Handle(instruction_->call()->ic_data()->target_name());
+ Array& argument_names =
+ Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
compiler->EmitMegamorphicInstanceCall(
- *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(),
+ selector, argument_names, instruction_->call()->ArgumentCount(),
instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
locs, try_index_,
/* slow_path_argument_count = */ 2);
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698