Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 2809583002: Use off-heap data for type feedback in PolymorphicInstanceCallInstr (Closed)
Patch Set: More feedback from Slava Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
3 // for details. All rights reserved. Use of this source code is governed by a 3 // for details. All rights reserved. Use of this source code is governed by a
4 // BSD-style license that can be found in the LICENSE file. 4 // BSD-style license that can be found in the LICENSE file.
5 5
6 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 6 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
7 #if defined(TARGET_ARCH_ARM) 7 #if defined(TARGET_ARCH_ARM)
8 8
9 #include "vm/intermediate_language.h" 9 #include "vm/intermediate_language.h"
10 10
(...skipping 3121 matching lines...) Expand 10 before | Expand all | Expand 10 after
3132 Register result = locs->out(0).reg(); 3132 Register result = locs->out(0).reg();
3133 locs->live_registers()->Remove(Location::RegisterLocation(result)); 3133 locs->live_registers()->Remove(Location::RegisterLocation(result));
3134 3134
3135 compiler->SaveLiveRegisters(locs); 3135 compiler->SaveLiveRegisters(locs);
3136 if (instruction_->env() != NULL) { 3136 if (instruction_->env() != NULL) {
3137 Environment* env = compiler->SlowPathEnvironmentFor(instruction_); 3137 Environment* env = compiler->SlowPathEnvironmentFor(instruction_);
3138 compiler->pending_deoptimization_env_ = env; 3138 compiler->pending_deoptimization_env_ = env;
3139 } 3139 }
3140 __ Push(locs->in(0).reg()); 3140 __ Push(locs->in(0).reg());
3141 __ Push(locs->in(1).reg()); 3141 __ Push(locs->in(1).reg());
3142 const String& selector =
3143 String::Handle(instruction_->call()->ic_data()->target_name());
3144 const Array& argument_names =
3145 Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
3142 compiler->EmitMegamorphicInstanceCall( 3146 compiler->EmitMegamorphicInstanceCall(
3143 *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(), 3147 selector, argument_names, instruction_->call()->ArgumentCount(),
3144 instruction_->call()->deopt_id(), instruction_->call()->token_pos(), 3148 instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
3145 locs, try_index_, 3149 locs, try_index_,
3146 /* slow_path_argument_count = */ 2); 3150 /* slow_path_argument_count = */ 2);
3147 __ mov(result, Operand(R0)); 3151 __ mov(result, Operand(R0));
3148 compiler->RestoreLiveRegisters(locs); 3152 compiler->RestoreLiveRegisters(locs);
3149 __ b(exit_label()); 3153 __ b(exit_label());
3150 compiler->pending_deoptimization_env_ = NULL; 3154 compiler->pending_deoptimization_env_ = NULL;
3151 } 3155 }
3152 3156
3153 private: 3157 private:
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
3271 Register result = merged_ ? locs->temp(0).reg() : locs->out(0).reg(); 3275 Register result = merged_ ? locs->temp(0).reg() : locs->out(0).reg();
3272 locs->live_registers()->Remove(Location::RegisterLocation(result)); 3276 locs->live_registers()->Remove(Location::RegisterLocation(result));
3273 3277
3274 compiler->SaveLiveRegisters(locs); 3278 compiler->SaveLiveRegisters(locs);
3275 if (instruction_->env() != NULL) { 3279 if (instruction_->env() != NULL) {
3276 Environment* env = compiler->SlowPathEnvironmentFor(instruction_); 3280 Environment* env = compiler->SlowPathEnvironmentFor(instruction_);
3277 compiler->pending_deoptimization_env_ = env; 3281 compiler->pending_deoptimization_env_ = env;
3278 } 3282 }
3279 __ Push(locs->in(0).reg()); 3283 __ Push(locs->in(0).reg());
3280 __ Push(locs->in(1).reg()); 3284 __ Push(locs->in(1).reg());
3285 String& selector =
3286 String::Handle(instruction_->call()->ic_data()->target_name());
3287 Array& argument_names =
3288 Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
3281 compiler->EmitMegamorphicInstanceCall( 3289 compiler->EmitMegamorphicInstanceCall(
3282 *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(), 3290 selector, argument_names, instruction_->call()->ArgumentCount(),
3283 instruction_->call()->deopt_id(), instruction_->call()->token_pos(), 3291 instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
3284 locs, try_index_, 3292 locs, try_index_,
3285 /* slow_path_argument_count = */ 2); 3293 /* slow_path_argument_count = */ 2);
3286 __ mov(result, Operand(R0)); 3294 __ mov(result, Operand(R0));
3287 compiler->RestoreLiveRegisters(locs); 3295 compiler->RestoreLiveRegisters(locs);
3288 compiler->pending_deoptimization_env_ = NULL; 3296 compiler->pending_deoptimization_env_ = NULL;
3289 if (merged_) { 3297 if (merged_) {
3290 __ CompareObject(result, Bool::True()); 3298 __ CompareObject(result, Bool::True());
3291 __ b( 3299 __ b(
3292 instruction_->is_negated() ? labels_.false_label : labels_.true_label, 3300 instruction_->is_negated() ? labels_.false_label : labels_.true_label,
(...skipping 3969 matching lines...) Expand 10 before | Expand all | Expand 10 after
7262 compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(), 7270 compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(),
7263 kGrowRegExpStackRuntimeEntry, 1, locs()); 7271 kGrowRegExpStackRuntimeEntry, 1, locs());
7264 __ Drop(1); 7272 __ Drop(1);
7265 __ Pop(result); 7273 __ Pop(result);
7266 } 7274 }
7267 7275
7268 7276
7269 } // namespace dart 7277 } // namespace dart
7270 7278
7271 #endif // defined TARGET_ARCH_ARM 7279 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698