Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2809493002: Reland "media: Implement MediaDrmStorageImpl with tests" with fix (Closed)

Created:
3 years, 8 months ago by xhwang
Modified:
3 years, 8 months ago
Reviewers:
yucliu1, sdefresne
CC:
chromium-reviews, eme-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "media: Implement MediaDrmStorageImpl with tests" with fix This reverts commit f5fa6d693cae9dfcdb66bdfd70752975c7d9bef4 with fix. Original CL description: Implement MediaDrmStorageImpl using PrefService. TBR=sdefresne@chromium.org BUG=493521, 709601 TEST=New unit tests added. Review-Url: https://codereview.chromium.org/2809493002 Cr-Commit-Position: refs/heads/master@{#463115} Committed: https://chromium.googlesource.com/chromium/src/+/e1197d0eff5daafdcd8f4991c6eb24c87b39c9ca

Patch Set 1 : revert of revert (original CL) #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -17 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/cdm/browser/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
M components/cdm/browser/media_drm_storage_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/cdm/browser/media_drm_storage_impl.cc View 1 12 chunks +162 lines, -17 lines 0 comments Download
A components/cdm/browser/media_drm_storage_impl_unittest.cc View 1 chunk +196 lines, -0 lines 0 comments Download
M media/base/android/media_drm_storage.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
xhwang
yucliu@: PTAL
3 years, 8 months ago (2017-04-08 00:35:10 UTC) #5
yucliu1
On 2017/04/08 00:35:10, xhwang_slow wrote: > yucliu@: PTAL lgtm
3 years, 8 months ago (2017-04-08 00:45:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809493002/20001
3 years, 8 months ago (2017-04-08 00:48:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e1197d0eff5daafdcd8f4991c6eb24c87b39c9ca
3 years, 8 months ago (2017-04-08 03:04:20 UTC) #12
sdefresne
3 years, 8 months ago (2017-04-10 10:26:41 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698