Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2809473003:
Switch DirectComposition layers to BGRA if overlay allocation fails. (Closed)
DescriptionSwitch DirectComposition layers to BGRA if overlay allocation fails.
If windows isn't using overlays then it's more efficient to use a
B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its
own colorspace conversion.
BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2809473003
Cr-Commit-Position: refs/heads/master@{#464272}
Committed: https://chromium.googlesource.com/chromium/src/+/2a486dc748205105abde688b4775f19703b272c6
Patch Set 1 #Patch Set 2 : improve #
Total comments: 3
Patch Set 3 : post-review changes #
Messages
Total messages: 26 (19 generated)
Description was changed from ========== Switch DirectComposition layers to BGRA if overlay allocation fails. If windows isn't using overlays then it's more efficient to use a B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its own colorspace conversion. BUG=678800 ========== to ========== Switch DirectComposition layers to BGRA if overlay allocation fails. If windows isn't using overlays then it's more efficient to use a B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its own colorspace conversion. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jbauman@chromium.org changed reviewers: + sunnyps@chromium.org
lgtm % nits https://codereview.chromium.org/2809473003/diff/20001/gpu/ipc/service/direct_... File gpu/ipc/service/direct_composition_surface_win.cc (right): https://codereview.chromium.org/2809473003/diff/20001/gpu/ipc/service/direct_... gpu/ipc/service/direct_composition_surface_win.cc:230: PresentationHistory history_; nit: presentation_history_ https://codereview.chromium.org/2809473003/diff/20001/gpu/ipc/service/direct_... gpu/ipc/service/direct_composition_surface_win.cc:550: HRESULT hr = E_FAIL; nit: can you rewrite to something like this: is_yuv2_swapchain_ = false; if (yuv2) { hr = media_factory->... is_yuv2_swapchain_ = SUCCEEDED(hr); failed_to_create_yuv2_swapchain_ = !is_yuv2_swapchain_; } if (!is_yuv2_swapchain_) { ... // don't set is_yuv2_swapchain_ here https://codereview.chromium.org/2809473003/diff/20001/gpu/ipc/service/direct_... gpu/ipc/service/direct_composition_surface_win.cc:559: // This should not be hit in production but is a simple fallback for nit: This comment needs to be updated.
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
jbauman@chromium.org changed reviewers: + isherman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbauman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org Link to the patchset: https://codereview.chromium.org/2809473003/#ps40001 (title: "post-review changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jbauman@chromium.org
The CQ bit was checked by jbauman@chromium.org
The CQ bit was unchecked by jbauman@chromium.org
The CQ bit was checked by jbauman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492052721336870,
"parent_rev": "2b71e084f0d11b7aee47096cbbd2144931760028", "commit_rev":
"2a486dc748205105abde688b4775f19703b272c6"}
Message was sent while issue was closed.
Description was changed from ========== Switch DirectComposition layers to BGRA if overlay allocation fails. If windows isn't using overlays then it's more efficient to use a B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its own colorspace conversion. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Switch DirectComposition layers to BGRA if overlay allocation fails. If windows isn't using overlays then it's more efficient to use a B8G8R8A8 swapchain instead of YUY2, as then windows won't have to do its own colorspace conversion. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2809473003 Cr-Commit-Position: refs/heads/master@{#464272} Committed: https://chromium.googlesource.com/chromium/src/+/2a486dc748205105abde688b4775... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2a486dc748205105abde688b4775... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
