Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2809413002: Sync histograms.xml with authpolicy's dbus-constants.h (Closed)

Created:
3 years, 8 months ago by ljusten (tachyonic)
Modified:
3 years, 8 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync histograms.xml with authpolicy's dbus-constants.h Codes are used internally only right now. Authpolicy shouldn't actually send them yet. This might be implemented in a future CL. BUG=chromium:676607 TEST=Squinted eyes to make sure XML is valid. Review-Url: https://codereview.chromium.org/2809413002 Cr-Commit-Position: refs/heads/master@{#464402} Committed: https://chromium.googlesource.com/chromium/src/+/7bd88f51679fefff4ce7fca4c44d814b28e0787d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ljusten (tachyonic)
Hey Mark, please take a look.
3 years, 8 months ago (2017-04-12 08:38:36 UTC) #2
Mark P
lgtm Though I should warn you that having an "unknown" state can be icky if ...
3 years, 8 months ago (2017-04-13 00:00:51 UTC) #3
ljusten (tachyonic)
On 2017/04/13 00:00:51, Mark P wrote: > Though I should warn you that having an ...
3 years, 8 months ago (2017-04-13 09:51:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809413002/1
3 years, 8 months ago (2017-04-13 09:51:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/421558)
3 years, 8 months ago (2017-04-13 10:46:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809413002/1
3 years, 8 months ago (2017-04-13 13:48:05 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 14:45:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bd88f51679fefff4ce7fca4c44d...

Powered by Google App Engine
This is Rietveld 408576698