Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7943)

Unified Diff: content/renderer/render_widget.cc

Issue 2809333002: WIP Logging for Contextual Search: Node->Element. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index ff49586a1752433c88bbbb7a6049b30d5b6f1f9c..6d486a4accb4dd8a714209d93f09ed73f6cd8074 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -2140,11 +2140,21 @@ blink::WebScreenInfo RenderWidget::GetScreenInfo() {
void RenderWidget::ShowUnhandledTapUIIfNeeded(const WebPoint& tapped_position,
const WebNode& tapped_node,
bool page_changed) {
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded";
DCHECK(input_handler_->handling_input_event());
bool should_trigger = !page_changed && tapped_node.IsTextNode() &&
!tapped_node.IsContentEditable() &&
!tapped_node.IsInsideFocusableElementOrARIAWidget();
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded should_trigger: " << should_trigger;
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded page_changed: " << page_changed;
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsTextNode: " << tapped_node.IsTextNode();
Donn Denman 2017/04/12 02:12:47 This is logging 0, needs to be 1.
hayato 2017/04/12 03:27:49 Ah, thanks! Let me try to update RenderWidget.
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsContentEditable: " << tapped_node.IsContentEditable();
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsInsideFocusableElementOrARIAWidget: "
+ << tapped_node.IsInsideFocusableElementOrARIAWidget();
+ // Dump the node value?
+ // VLOG(0) << "ctxs RenderWidget::tapped_node: " << tapped_node.NodeValue().;
if (should_trigger) {
+ VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded sending viewHostMsg";
Send(new ViewHostMsg_ShowUnhandledTapUIIfNeeded(routing_id_,
tapped_position.x, tapped_position.y));
}

Powered by Google App Engine
This is Rietveld 408576698