Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: content/renderer/render_widget.cc

Issue 2809333002: WIP Logging for Contextual Search: Node->Element. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2133 break; 2133 break;
2134 } 2134 }
2135 web_screen_info.orientation_angle = screen_info_.orientation_angle; 2135 web_screen_info.orientation_angle = screen_info_.orientation_angle;
2136 return web_screen_info; 2136 return web_screen_info;
2137 } 2137 }
2138 2138
2139 #if defined(OS_ANDROID) 2139 #if defined(OS_ANDROID)
2140 void RenderWidget::ShowUnhandledTapUIIfNeeded(const WebPoint& tapped_position, 2140 void RenderWidget::ShowUnhandledTapUIIfNeeded(const WebPoint& tapped_position,
2141 const WebNode& tapped_node, 2141 const WebNode& tapped_node,
2142 bool page_changed) { 2142 bool page_changed) {
2143 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded";
2143 DCHECK(input_handler_->handling_input_event()); 2144 DCHECK(input_handler_->handling_input_event());
2144 bool should_trigger = !page_changed && tapped_node.IsTextNode() && 2145 bool should_trigger = !page_changed && tapped_node.IsTextNode() &&
2145 !tapped_node.IsContentEditable() && 2146 !tapped_node.IsContentEditable() &&
2146 !tapped_node.IsInsideFocusableElementOrARIAWidget(); 2147 !tapped_node.IsInsideFocusableElementOrARIAWidget();
2148 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded should_trigger: " << should_trigger;
2149 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded page_changed: " << p age_changed;
2150 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsTextNode: " << tap ped_node.IsTextNode();
Donn Denman 2017/04/12 02:12:47 This is logging 0, needs to be 1.
hayato 2017/04/12 03:27:49 Ah, thanks! Let me try to update RenderWidget.
2151 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsContentEditable: " << tapped_node.IsContentEditable();
2152 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded IsInsideFocusableEle mentOrARIAWidget: "
2153 << tapped_node.IsInsideFocusableElementOrARIAWidget();
2154 // Dump the node value?
2155 // VLOG(0) << "ctxs RenderWidget::tapped_node: " << tapped_node.NodeValue().;
2147 if (should_trigger) { 2156 if (should_trigger) {
2157 VLOG(0) << "ctxs RenderWidget::ShowUnhandledTapUIIfNeeded sending viewHostMs g";
2148 Send(new ViewHostMsg_ShowUnhandledTapUIIfNeeded(routing_id_, 2158 Send(new ViewHostMsg_ShowUnhandledTapUIIfNeeded(routing_id_,
2149 tapped_position.x, tapped_position.y)); 2159 tapped_position.x, tapped_position.y));
2150 } 2160 }
2151 } 2161 }
2152 #endif 2162 #endif
2153 2163
2154 void RenderWidget::DidHandleGestureEvent(const WebGestureEvent& event, 2164 void RenderWidget::DidHandleGestureEvent(const WebGestureEvent& event,
2155 bool event_cancelled) { 2165 bool event_cancelled) {
2156 #if defined(OS_ANDROID) || defined(USE_AURA) 2166 #if defined(OS_ANDROID) || defined(USE_AURA)
2157 if (event_cancelled) 2167 if (event_cancelled)
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
2314 // browser side (https://crbug.com/669219). 2324 // browser side (https://crbug.com/669219).
2315 // If there is no WebFrameWidget, then there will be no 2325 // If there is no WebFrameWidget, then there will be no
2316 // InputMethodControllers for a WebLocalFrame. 2326 // InputMethodControllers for a WebLocalFrame.
2317 return nullptr; 2327 return nullptr;
2318 } 2328 }
2319 return static_cast<blink::WebFrameWidget*>(GetWebWidget()) 2329 return static_cast<blink::WebFrameWidget*>(GetWebWidget())
2320 ->GetActiveWebInputMethodController(); 2330 ->GetActiveWebInputMethodController();
2321 } 2331 }
2322 2332
2323 } // namespace content 2333 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698