Hide profiles behind a command-line switch since the user-data-dir stuff...

Hide profiles behind a command-line switch since the user-data-dir stuff
wouldn't work on Mac.

See bug http://code.google.com/p/chromium/issues/detail?id=7987


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10432

[Finnur, 2009-02-24 22:30:40]

LG. Just nits:

http://codereview.chromium.org/28093/diff/1/3
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/28093/diff/1/3#newcode565
Line 565: l10n_util::GetString(IDS_PROFILE_MENU));
Wasn't there also code somewhere to add sub-menus under this menu? (for each
profile)

http://codereview.chromium.org/28093/diff/1/5
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/28093/diff/1/5#newcode124
Line 124: const wchar_t kEnableProfiles[] = L"enable-profiles";
This should be indented, like the rest of the string values.

--enable-profiles
... isn't that misleading though? Profile's aren't disabled if this flag is
missing, you still have *a* profile...

[Munjal (Google), 2009-02-25 01:02:32]

Finnur, thanks for the quick review. See the latest patch set.

http://codereview.chromium.org/28093/diff/1/3
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/28093/diff/1/3#newcode565
Line 565: l10n_util::GetString(IDS_PROFILE_MENU));
On 2009/02/24 22:30:40, Finnur wrote:
> Wasn't there also code somewhere to add sub-menus under this menu? (for each
> profile)

Yes, it's the OnGetProfilesDone function (as the comment says above). But we
don't need to guard that with command-line present check since that wouldn't run
if this code snippet doesn't run.

http://codereview.chromium.org/28093/diff/1/5
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/28093/diff/1/5#newcode124
Line 124: const wchar_t kEnableProfiles[] = L"enable-profiles";
On 2009/02/24 22:30:40, Finnur wrote:
> This should be indented, like the rest of the string values.
> 
> --enable-profiles
> ... isn't that misleading though? Profile's aren't disabled if this flag is
> missing, you still have *a* profile...

Done.
I changed the flag to --enable-udd-profiles and renamed the variable too.

[sky, 2009-02-25 01:07:36]

Does this also take care of the accelerators?

[sky, 2009-02-25 15:37:59]

Did you forget to include browser.cc in the latest?

http://codereview.chromium.org/28093/diff/22/1020
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/28093/diff/22/1020#newcode38
Line 38: #include "chrome/common/chrome_switches.h"
nit: keep the includes alphabetized.

[Munjal (Google), 2009-02-25 17:35:26]

Sorry for the sloppiness. I was trying to finish up this CL yesterday evening
when I was rushing to reach some place at 5:30.

http://codereview.chromium.org/28093/diff/22/1020
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/28093/diff/22/1020#newcode38
Line 38: #include "chrome/common/chrome_switches.h"
On 2009/02/25 15:37:59, sky wrote:
> nit: keep the includes alphabetized.

Done.

[sky, 2009-02-25 17:38:25]

LGTM