Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 28093: Hide profiles behind a command-line switch since the user-data-dir stuff... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by Munjal (Google)
Modified:
5 years, 9 months ago
Reviewers:
Finnur, Mark Larson, sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Hide profiles behind a command-line switch since the user-data-dir stuff wouldn't work on Mac. See bug http://code.google.com/p/chromium/issues/detail?id=7987 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10432

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/browser.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/user_data_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 2 3 4 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (0 generated)
Munjal (Google)
8 years, 7 months ago (2009-02-24 22:00:20 UTC) #1
Finnur
LG. Just nits: http://codereview.chromium.org/28093/diff/1/3 File chrome/browser/views/toolbar_view.cc (right): http://codereview.chromium.org/28093/diff/1/3#newcode565 Line 565: l10n_util::GetString(IDS_PROFILE_MENU)); Wasn't there also code ...
8 years, 7 months ago (2009-02-24 22:30:40 UTC) #2
Munjal (Google)
Finnur, thanks for the quick review. See the latest patch set. http://codereview.chromium.org/28093/diff/1/3 File chrome/browser/views/toolbar_view.cc (right): ...
8 years, 7 months ago (2009-02-25 01:02:32 UTC) #3
sky
Does this also take care of the accelerators?
8 years, 7 months ago (2009-02-25 01:07:36 UTC) #4
sky
Did you forget to include browser.cc in the latest? http://codereview.chromium.org/28093/diff/22/1020 File chrome/browser/views/toolbar_view.cc (right): http://codereview.chromium.org/28093/diff/22/1020#newcode38 Line ...
8 years, 7 months ago (2009-02-25 15:37:59 UTC) #5
Munjal (Google)
Sorry for the sloppiness. I was trying to finish up this CL yesterday evening when ...
8 years, 7 months ago (2009-02-25 17:35:26 UTC) #6
sky
8 years, 7 months ago (2009-02-25 17:38:25 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b