android: assert runningOnLauncherThread

android: assert runningOnLauncherThread

This change is meant to have no production impact. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
Review-Url: https://codereview.chromium.org/2809293005
Cr-Commit-Position: refs/heads/master@{#464498}
Committed: https://chromium.googlesource.com/chromium/src/+/06114d78b56a1f73eeede3514c06bcb0aa33a942

[boliu, 2017-04-12 19:47:18]

Description was changed from

==========
android: assert runningOnLauncherThread

This change is meant to have no production impct. Add assert to methods
that already only running on launcher thread as such. This involves a
lot of changes in tests though since test often assume things are thread
safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
==========

to

==========
android: assert runningOnLauncherThread

This change is meant to have no production impct. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
==========

[boliu, 2017-04-12 23:00:17]

boliu@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[boliu, 2017-04-12 23:00:17]

ptal

can't land this yet, because the asserts in this CL made clear that native and
java launcher are two separate threads right now :p fix for that here:
https://codereview.chromium.org/2808343004/

but figure can send it out for review now, and as a heads up to jay

[Maria, 2017-04-12 23:38:15]

lgtm

https://codereview.chromium.org/2809293005/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
(left):

https://codereview.chromium.org/2809293005/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:556:
}
yay for these things not being here!

[boliu, 2017-04-13 18:34:34]

Description was changed from

==========
android: assert runningOnLauncherThread

This change is meant to have no production impct. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
==========

to

==========
android: assert runningOnLauncherThread

This change is meant to have no production impact. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
==========

[boliu, 2017-04-13 18:34:47]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:36:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:21:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492108487362290,
"parent_rev": "092d3492acf064752a5776b4fd07ac21d39d2a98", "commit_rev":
"06114d78b56a1f73eeede3514c06bcb0aa33a942"}

[commit-bot: I haz the power, 2017-04-13 19:22:29]

Description was changed from

==========
android: assert runningOnLauncherThread

This change is meant to have no production impact. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758
==========

to

==========
android: assert runningOnLauncherThread

This change is meant to have no production impact. Add assert to methods
that already only running on launcher thread in production. This involves
a lot of changes in tests though since test often assume things are
thread safe. This includes moving some helper methods from
ChildProcessLauncherTest to ChildProcessLauncherTestHelperService so
they can be shared.

Also take this opportunity to move a bunch of ForTesting methods from
ChildProcessLauncher to actual test file. This does involve exposing
other things and marking them as @VisibleForTesting, but imo removing
stuff from ChildProcessLauncher is a good thing.

BUG=689758

Review-Url: https://codereview.chromium.org/2809293005
Cr-Commit-Position: refs/heads/master@{#464498}
Committed:
https://chromium.googlesource.com/chromium/src/+/06114d78b56a1f73eeede3514c06...
==========

[commit-bot: I haz the power, 2017-04-13 19:22:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06114d78b56a1f73eeede3514c06...