Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2809263006: [Remote scheduler] Adapt the M59 defaults to M57 Stable results (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remote scheduler] Adapt the M59 defaults to M57 Stable results This CL adapts the M59 defaults for remote suggestions scheduler to observations from M57 soft fetches rollout. It also, targetting EM, sets cellular soft interval values to 2x of corresponding wifi values. BUG=672479 Review-Url: https://codereview.chromium.org/2809263006 Cr-Commit-Position: refs/heads/master@{#464412} Committed: https://chromium.googlesource.com/chromium/src/+/e24cd6767ef345d4b2865d31218c1e7be14de039

Patch Set 1 #

Patch Set 2 : Fix unit-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
jkrcal
Marc, the last planned pre-BP CL, I promise! :) Could you PTAL?
3 years, 8 months ago (2017-04-13 11:32:06 UTC) #2
Marc Treib
lgtm Hint: You might not want to post links to internal docs on public CLs, ...
3 years, 8 months ago (2017-04-13 11:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809263006/20001
3 years, 8 months ago (2017-04-13 14:44:37 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:25:46 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e24cd6767ef345d4b2865d31218c...

Powered by Google App Engine
This is Rietveld 408576698