Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025, 710968
Review-Url: https://codereview.chromium.org/2809223003
Cr-Commit-Position: refs/heads/master@{#464377}
Committed: https://chromium.googlesource.com/chromium/src/+/16904d20070be165ac263fa38155d6174c8839ca

[David Trainor- moved to gerrit, 2017-04-12 16:09:21]

dtrainor@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-12 16:09:21]

lgtm

[bsazonov, 2017-04-12 16:09:25]

David, PTAL.

[bsazonov, 2017-04-12 16:12:51]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:13:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:53:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[bsazonov, 2017-04-12 18:41:54]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-12 18:45:32]

lgtm thanks!

[bsazonov, 2017-04-12 19:01:10]

Description was changed from

==========
Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025
==========

to

==========
Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025,710968
==========

[commit-bot: I haz the power, 2017-04-12 20:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 20:40:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[bsazonov, 2017-04-13 09:35:02]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 09:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 10:07:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 10:07:51]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-04-13 11:47:57]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-04-13 11:47:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2809223003/#ps40001
(title: "Fix tests on KitKat (ServiceTestCase is buggy on KitKat)")

[commit-bot: I haz the power, 2017-04-13 11:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 11:56:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492084077536210,
"parent_rev": "e87bbc88306d3bbac6249887d846077c8d0f923b", "commit_rev":
"16904d20070be165ac263fa38155d6174c8839ca"}

[commit-bot: I haz the power, 2017-04-13 11:57:13]

Description was changed from

==========
Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025,710968
==========

to

==========
Fix DownloadNotificationService crash caused by early getLastUsedProfile() call

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025,710968

Review-Url: https://codereview.chromium.org/2809223003
Cr-Commit-Position: refs/heads/master@{#464377}
Committed:
https://chromium.googlesource.com/chromium/src/+/16904d20070be165ac263fa38155...
==========

[commit-bot: I haz the power, 2017-04-13 11:57:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/16904d20070be165ac263fa38155...