Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2809213003: Blink Rename follow-up: BRs --big-rename--> _b_rs --this-fix--> _brs. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Rename follow-up: BRs --big-rename--> _b_rs --this-fix--> _brs. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2809213003 Cr-Commit-Position: refs/heads/master@{#463790} Committed: https://chromium.googlesource.com/chromium/src/+/42dcba91524903cd72eac79865d7fd0b3d23bee6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Łukasz Anforowicz
dcheng@, could you PTAL?
3 years, 8 months ago (2017-04-11 20:17:30 UTC) #5
dcheng
LGTM (Do you have a heuristic you're using to find these?)
3 years, 8 months ago (2017-04-11 21:37:01 UTC) #6
Łukasz Anforowicz
On 2017/04/11 21:37:01, dcheng wrote: > LGTM > > (Do you have a heuristic you're ...
3 years, 8 months ago (2017-04-11 21:46:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809213003/1
3 years, 8 months ago (2017-04-11 21:47:14 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:58:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42dcba91524903cd72eac79865d7...

Powered by Google App Engine
This is Rietveld 408576698