Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2809183003: [wrapper-tracing] Fix node list leak (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 2f287b36a75b8f9d58f0cfc4f61b89788eb359e6..a847b0869c535f6b0524bbf9a438bb822a44d1c3 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -6634,17 +6634,6 @@ DEFINE_TRACE_WRAPPERS(Document) {
visitor->TraceWrappers(implementation_);
visitor->TraceWrappers(style_sheet_list_);
visitor->TraceWrappers(style_engine_);
sof 2017/04/12 06:51:50 Add a comment saying why/where node_lists_ are tak
Michael Lippautz 2017/04/12 08:06:33 Done.
- for (int i = 0; i < kNumNodeListInvalidationTypes; ++i) {
- for (auto list : node_lists_[i]) {
- if (IsHTMLCollectionType(list->GetType())) {
- visitor->TraceWrappersWithManualWriteBarrier(
- static_cast<const HTMLCollection*>(list.Get()));
- } else {
- visitor->TraceWrappersWithManualWriteBarrier(
- static_cast<const LiveNodeList*>(list.Get()));
- }
- }
- }
// Cannot trace in Supplementable<Document> as it is part of platform/ and
// thus cannot refer to ScriptWrappableVisitor.
visitor->TraceWrappers(

Powered by Google App Engine
This is Rietveld 408576698