Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2809173002: Add support in widget to open search modes + copied link in app. (Closed)

Created:
3 years, 8 months ago by lody
Modified:
3 years, 8 months ago
Reviewers:
jif, lpromero
CC:
chromium-reviews, extensions-reviews_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support in widget to open search modes + copied link in app. This CL adds the functionality to open the 4 search modes in the main application: regular, incognito, voice and qr code. UI support will be in a future CL. BUG=622743 TBR=jif Review-Url: https://codereview.chromium.org/2809173002 Cr-Commit-Position: refs/heads/master@{#464386} Committed: https://chromium.googlesource.com/chromium/src/+/05fc00380f61c37f8a8ea149f779cdb677a14e22

Patch Set 1 #

Total comments: 36

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : remove unnecessary call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -26 lines) Patch
M ios/chrome/widget_extension/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
A ios/chrome/widget_extension/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/widget_extension/widget_view.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M ios/chrome/widget_extension/widget_view.mm View 1 4 chunks +11 lines, -1 line 0 comments Download
M ios/chrome/widget_extension/widget_view_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/widget_extension/widget_view_controller.mm View 1 2 3 chunks +152 lines, -20 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
lody
lpromero, please review. Thanks. jif, please review for use of open_from_clipboard. https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/widget_view.h File ios/chrome/widget_extension/widget_view.h (right): ...
3 years, 8 months ago (2017-04-11 12:56:01 UTC) #2
lpromero
https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/DEPS File ios/chrome/widget_extension/DEPS (right): https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/DEPS#newcode2 ios/chrome/widget_extension/DEPS:2: "+components/open_from_clipboard", Can you also forbid "url"? https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/widget_view.h File ios/chrome/widget_extension/widget_view.h ...
3 years, 8 months ago (2017-04-11 13:24:04 UTC) #3
lody
https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/DEPS File ios/chrome/widget_extension/DEPS (right): https://codereview.chromium.org/2809173002/diff/1/ios/chrome/widget_extension/DEPS#newcode2 ios/chrome/widget_extension/DEPS:2: "+components/open_from_clipboard", On 2017/04/11 13:24:03, lpromero wrote: > Can you ...
3 years, 8 months ago (2017-04-11 14:38:19 UTC) #5
lpromero
lgtm https://codereview.chromium.org/2809173002/diff/40001/ios/chrome/widget_extension/widget_view_controller.mm File ios/chrome/widget_extension/widget_view_controller.mm (right): https://codereview.chromium.org/2809173002/diff/40001/ios/chrome/widget_extension/widget_view_controller.mm#newcode75 ios/chrome/widget_extension/widget_view_controller.mm:75: [self updateWidget]; Is this still needed here given ...
3 years, 8 months ago (2017-04-11 15:05:29 UTC) #6
lody
As explained offline will land this + dependent CL then add tests. https://codereview.chromium.org/2809173002/diff/40001/ios/chrome/widget_extension/widget_view_controller.mm File ios/chrome/widget_extension/widget_view_controller.mm ...
3 years, 8 months ago (2017-04-13 11:39:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809173002/60001
3 years, 8 months ago (2017-04-13 11:40:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410319)
3 years, 8 months ago (2017-04-13 11:47:21 UTC) #12
lody
TBR jif for ownership of clipboardrecentcontents.
3 years, 8 months ago (2017-04-13 11:48:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809173002/60001
3 years, 8 months ago (2017-04-13 11:49:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/05fc00380f61c37f8a8ea149f779cdb677a14e22
3 years, 8 months ago (2017-04-13 12:50:22 UTC) #19
jif
3 years, 8 months ago (2017-04-18 12:06:50 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698