Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2809143003: [regexp] remove \p{Other_ID_Start} and \p{Other_ID_Continue} (Closed)

Created:
3 years, 8 months ago by mathias
Modified:
3 years, 8 months ago
Reviewers:
Yang, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] remove \p{Other_ID_Start} and \p{Other_ID_Continue} The spec proposal has been updated to drop contributory binary properties such as `Other_ID_Start` and `Other_ID_Continue`. This patch reverts commit 26e5d0129ca501e4dbadaa098e65222687ce4ab0 and adds tests to ensure these properties are not supported. R= BUG=v8:4743 Review-Url: https://codereview.chromium.org/2809143003 Cr-Commit-Position: refs/heads/master@{#44569} Committed: https://chromium.googlesource.com/v8/v8/+/f956279ed618f026cec357b4a36f0efcc77e2fd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -65 lines) Patch
M src/regexp/regexp-parser.cc View 5 chunks +18 lines, -56 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-special.js View 1 chunk +23 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mathias
3 years, 8 months ago (2017-04-11 11:53:32 UTC) #3
Yang
On 2017/04/11 11:53:32, mathias wrote: LGTM. Thanks...
3 years, 8 months ago (2017-04-11 11:56:06 UTC) #4
jgruber
lgtm
3 years, 8 months ago (2017-04-11 11:57:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809143003/1
3 years, 8 months ago (2017-04-11 12:13:51 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 12:40:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f956279ed618f026cec357b4a36f0efcc77...

Powered by Google App Engine
This is Rietveld 408576698