Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2809133002: Create the control buttons on a notification when showing the buttons if needed. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org, Eliot Courtney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create the control buttons on a notification when showing the buttons if needed. BUG=709862 Review-Url: https://codereview.chromium.org/2809133002 Cr-Commit-Position: refs/heads/master@{#463947} Committed: https://chromium.googlesource.com/chromium/src/+/9871ced334b179dbe05c98c9e99bca5114a3bc5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
yhanada
PTAL
3 years, 8 months ago (2017-04-11 08:03:03 UTC) #4
yoshiki
lgtm
3 years, 8 months ago (2017-04-12 07:29:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809133002/1
3 years, 8 months ago (2017-04-12 07:33:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 07:49:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9871ced334b179dbe05c98c9e99b...

Powered by Google App Engine
This is Rietveld 408576698